Skip to content

ui: fix tags selection for add disk offering#4665

Merged
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-ui-add-disk-off-tags
Feb 12, 2021
Merged

ui: fix tags selection for add disk offering#4665
yadvr merged 1 commit intoapache:4.15from
shapeblue:fix-ui-add-disk-off-tags

Conversation

@shwstppr
Copy link
Contributor

@shwstppr shwstppr commented Feb 8, 2021

Description

Multiple entries were showing in tag selection dropdown of Add disk offering form.

Screenshot from 2021-02-08 18-48-16

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Screenshot from 2021-02-08 18-48-26

How Has This Been Tested?

With UI

  • Add same tag in different primary stores belonging to different clusters
  • Try to create a new disk offering
  • Tag selection dropdown will show same tag multiple times (same number as of primary stores to which the tag was added)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr added this to the 4.15.1.0 milestone Feb 8, 2021
@shwstppr
Copy link
Contributor Author

shwstppr commented Feb 8, 2021

@blueorangutan ui

@blueorangutan
Copy link

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/4665 (JID-3833)

Copy link

@utchoang utchoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yadvr yadvr merged commit 0d04bd6 into apache:4.15 Feb 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants